Feat: Data source project #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Mok-Nelson
requested review from
a team,
yaroslav-codefresh and
denis-codefresh
as code owners
|
/test |
|
Sorry for the delay and thanks for the contribution. I will have to take over the branch, add some tests and also run |
|
@Jake-Mok-Nelson I will be taking over this PR, will try to get it merged this week. Pushed some changes to your branch (merged from our upstream and added docs) |
|
/test |
1 similar comment
|
/test |
ilia-medvedev-codefresh
changed the title
ilia-medvedev-codefresh
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Create a project data resource for the Terraform Codefresh provider
Fixes #116
Why
A project data resource would allow us to perform validation before allowing a pipeline to target a project that may or may not exist. Ordinarily you'd just target the project resource but pipelines are not always created in the same location as the projects.
Notes
I have no ability to test this at the moment (I do not have connectivity to a Codefresh system), I'm hoping you can validate that it's good.
Checklist
/testcomment will be ignored by the CI trigger unless it is made by a repo admin or collaborator.